netdev - Re: [PATCH v3 net-next 5/8] net: dsa: b53: add MTU configuration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca7e48c2-249a-9066-045f-04708474ef8a@gmail.com>
Date:   Thu, 26 Mar 2020 16:16:38 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, andrew@...n.ch,
        vivien.didelot@...il.com, davem@...emloft.net,
        jakub.kicinski@...ronome.com
Cc:     murali.policharla@...adcom.com, stephen@...workplumber.org,
        jiri@...nulli.us, idosch@...sch.org, kuba@...nel.org,
        nikolay@...ulusnetworks.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 5/8] net: dsa: b53: add MTU configuration
 support



On 3/26/2020 3:40 PM, Vladimir Oltean wrote:
> From: Murali Krishna Policharla <murali.policharla@...adcom.com>
> 
> It looks like the Broadcomm switches supported by the b53 driver don't
                            ^= one too many m's, the attempt to acquire
Qualcomm failed a few years ago :)

> support precise configuration of the MTU, but just a mumbo-jumbo boolean
> flag. Set that.
> 
> Also configure BCM583XX devices to send and receive jumbo frames when
> ports are configured with 10/100 Mbps speed.
> 
> Signed-off-by: Murali Krishna Policharla <murali.policharla@...adcom.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---

[snip]

> +static int b53_change_mtu(struct dsa_switch *ds, int port, int mtu)
> +{
> +	struct b53_device *dev = ds->priv;
> +	bool enable_jumbo;
> +	bool allow_10_100;
> +
> +	if (is5325(dev) || is5365(dev))
> +		return -EOPNOTSUPP;
> +
> +	enable_jumbo = (mtu >= JMS_MIN_SIZE);
> +	allow_10_100 = (dev->chip_id == BCM58XX_DEVICE_ID);

I believe this was meant to be BCM583XX_DEVICE_ID to be consistent with
the previous patch version. With that:

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian