netdev - [PATCH net-next 0/6] mlxsw: Various static checkers fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200327085525.1906170-1-idosch@idosch.org>
Date:   Fri, 27 Mar 2020 11:55:19 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     netdev@...r.kernel.org
Cc:     davem@...emloft.net, jiri@...lanox.com, kuba@...nel.org,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: [PATCH net-next 0/6] mlxsw: Various static checkers fixes

From: Ido Schimmel <idosch@...lanox.com>

Jakub told me he gets some warnings with W=1, so I decided to check with
sparse, smatch and coccinelle as well. This patch set fixes all the
issues found. None are actual bugs / regressions and therefore not
targeted at net.

Patches #1-#2 add missing kernel-doc comments.

Patch #3 removes dead code.

Patch #4 reworks the ACL code to avoid defining a static variable in a
header file.

Patch #5 removes unnecessary conversion to bool that coccinelle warns
about.

Patch #6 avoids false-positive uninitialized symbol errors emitted by
smatch.

Ido Schimmel (6):
  mlxsw: i2c: Add missing field documentation
  mlxsw: spectrum_router: Add proper function documentation
  mlxsw: spectrum: Remove unused RIF and FID families
  mlxsw: core_acl: Avoid defining static variable in header file
  mlxsw: switchx2: Remove unnecessary conversion to bool
  mlxsw: spectrum_router: Avoid uninitialized symbol errors

 .../mellanox/mlxsw/core_acl_flex_keys.c       |  50 +++++-
 .../mellanox/mlxsw/core_acl_flex_keys.h       |  36 +---
 drivers/net/ethernet/mellanox/mlxsw/i2c.c     |   1 +
 .../ethernet/mellanox/mlxsw/spectrum_fid.c    | 152 +---------------
 .../ethernet/mellanox/mlxsw/spectrum_router.c | 164 ++++++------------
 .../net/ethernet/mellanox/mlxsw/switchx2.c    |   2 +-
 6 files changed, 109 insertions(+), 296 deletions(-)

-- 
2.24.1