netdev - Re: [PATCH net-next v2 12/12] ethtool: provide timestamping information with TIMESTAMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Mar 2020 11:56:13 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Linville <linville@...driver.com>,
        Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 12/12] ethtool: provide timestamping
 information with TIMESTAMP_GET request

On Fri, Mar 27, 2020 at 03:08:17PM +0100, Michal Kubecek wrote:
> +/* TIMESTAMP */
> +
> +enum {
> +	ETHTOOL_A_TIMESTAMP_UNSPEC,

I suggest using ETHTOOL_A_TSINFO_ throughout.  After all, this API
does not provide time stamps, and we want to avoid confusion.

> +	ETHTOOL_A_TIMESTAMP_HEADER,			/* nest - _A_HEADER_* */
> +	ETHTOOL_A_TIMESTAMP_TIMESTAMPING,		/* bitset */
> +	ETHTOOL_A_TIMESTAMP_TX_TYPES,			/* bitset */
> +	ETHTOOL_A_TIMESTAMP_RX_FILTERS,			/* bitset */
> +	ETHTOOL_A_TIMESTAMP_PHC_INDEX,			/* u32 */
> +
> +	/* add new constants above here */
> +	__ETHTOOL_A_TIMESTAMP_CNT,
> +	ETHTOOL_A_TIMESTAMP_MAX = (__ETHTOOL_A_TIMESTAMP_CNT - 1)
> +};

Acked-by: Richard Cochran <richardcochran@...il.com>