netdev - [PATCH] net: dsa: mv88e6xxx: don't force settings on CPU port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200327195156.1728163-1-daniel@zonque.org>
Date:   Fri, 27 Mar 2020 20:51:56 +0100
From:   Daniel Mack <daniel@...que.org>
To:     andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Daniel Mack <daniel@...que.org>
Subject: [PATCH] net: dsa: mv88e6xxx: don't force settings on CPU port

On hardware with a speed-reduced link to the CPU port, forcing the MAC
settings won't allow any packets to pass. The PHY will negotiate the
maximum possible speed, so let's allow the MAC to work with whatever
is available.

Signed-off-by: Daniel Mack <daniel@...que.org>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 2f993e673ec7..48808c4add4f 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -2426,7 +2426,7 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)
 	 * state to any particular values on physical ports, but force the CPU
 	 * port and all DSA ports to their maximum bandwidth and full duplex.
 	 */
-	if (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port))
+	if (dsa_is_dsa_port(ds, port))
 		err = mv88e6xxx_port_setup_mac(chip, port, LINK_FORCED_UP,
 					       SPEED_MAX, DUPLEX_FULL,
 					       PAUSE_OFF,
-- 
2.25.1