netdev - Re: [PATCH net-next] net: dsa: mt7530: use resolved link config in mac_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 28 Mar 2020 04:25:14 +0800
From:   <sean.wang@...iatek.com>
To:     <netdev@...r.kernel.org>
CC:     <sean.wang@...iatek.com>, <frank-w@...lic-files.de>,
        <landen.chao@...iatek.com>, <andrew@...n.ch>,
        <vivien.didelot@...il.com>, <f.fainelli@...il.com>,
        <davem@...emloft.net>, <matthias.bgg@...il.com>,
        <linux@...linux.org.uk>, <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH net-next] net: dsa: mt7530: use resolved link config in mac_link_up()

From: Sean Wang <sean.wang@...iatek.com>

>Convert the mt7530 switch driver to use the finalised link parameters in mac_link_up() rather than the parameters in mac_config().
>
>Signed-off-by: René van Dorst <opensource@...rst.com>

That patch works well with either TRGMI on RGMII mode on MT7623 reference board.

Tested-by: Sean Wang <sean.wang@...iatek.com>

>---
> drivers/net/dsa/mt7530.c | 57 +++++++++++++++++-----------------------
> drivers/net/dsa/mt7530.h |  4 +++
> 2 files changed, 28 insertions(+), 33 deletions(-)
>
>diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 6e91fe2f4b9a..ef57552db260 100644
>--- a/drivers/net/dsa/mt7530.c
>+++ b/drivers/net/dsa/mt7530.c
>@@ -563,17 +563,6 @@ mt7530_mib_reset(struct dsa_switch *ds)
> 	mt7530_write(priv, MT7530_MIB_CCR, CCR_MIB_ACTIVATE);  }
> 
>-static void
>-mt7530_port_set_status(struct mt7530_priv *priv, int port, int enable) -{
>-	u32 mask = PMCR_TX_EN | PMCR_RX_EN | PMCR_FORCE_LNK;
>-
>-	if (enable)
>-		mt7530_set(priv, MT7530_PMCR_P(port), mask);
>-	else
>-		mt7530_clear(priv, MT7530_PMCR_P(port), mask);
>-}
>-
>