netdev - Re: [PATCH net-next] net: phy: don't touch suspended flag if there's no suspend/resume callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200326.203008.725583123135834564.davem@davemloft.net>
Date:   Thu, 26 Mar 2020 20:30:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, linux@...linux.org.uk,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: don't touch suspended flag if
 there's no suspend/resume callback

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 26 Mar 2020 18:58:24 +0100

> So far we set phydev->suspended to true in phy_suspend() even if the
> PHY driver doesn't implement the suspend callback. This applies
> accordingly for the resume path. The current behavior doesn't cause
> any issue I'd be aware of, but it's not logical and misleading,
> especially considering the description of the flag:
> "suspended: Set to true if this phy has been suspended successfully"
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thanks.