netdev - RE: [EXT] Re: [PATCH 5/8] qedf: Add schedule recovery handler.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR18MB25270CB792DECDD9D2E0CFB0D2CC0@MN2PR18MB2527.namprd18.prod.outlook.com>
Date:   Fri, 27 Mar 2020 04:32:52 +0000
From:   Saurav Kashyap <skashyap@...vell.com>
To:     David Miller <davem@...emloft.net>
CC:     "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH 5/8] qedf: Add schedule recovery handler.

Hi David,

> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: Friday, March 27, 2020 12:05 AM
> To: Saurav Kashyap <skashyap@...vell.com>
> Cc: martin.petersen@...cle.com; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@...vell.com>; linux-scsi@...r.kernel.org;
> netdev@...r.kernel.org
> Subject: [EXT] Re: [PATCH 5/8] qedf: Add schedule recovery handler.
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: Saurav Kashyap <skashyap@...vell.com>
> Date: Thu, 26 Mar 2020 00:08:03 -0700
> 
> > --- a/drivers/scsi/qedf/qedf_main.c
> > +++ b/drivers/scsi/qedf/qedf_main.c
> > @@ -3825,6 +3827,45 @@ static void qedf_shutdown(struct pci_dev
> *pdev)
> >  	__qedf_remove(pdev, QEDF_MODE_NORMAL);
> >  }
> >
> > +/*
> > + * Recovery handler code
> > + */
> > +void qedf_schedule_recovery_handler(void *dev)
>  ...
> > +void qedf_recovery_handler(struct work_struct *work)
> 
> These two functions are not referenced outside of this file, mark them
> static.

Thanks for feedback, will wait for other reviews and will submit v2.

Thanks,
~Saurav