netdev - Re: [PATCH bpf-next 4/7] bpf: allow to retrieve cgroup v1 classid from v2 hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzY5dd-wXbLziCQJOgikY-qvD+GQC=9HHZGCqmM_R-2mJA@mail.gmail.com>
Date:   Fri, 27 Mar 2020 17:41:34 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Martynas Pumputis <m@...bda.lt>,
        Joe Stringer <joe@...d.net.nz>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next 4/7] bpf: allow to retrieve cgroup v1 classid
 from v2 hooks

On Fri, Mar 27, 2020 at 9:00 AM Daniel Borkmann <daniel@...earbox.net> wrote:
>
> Today, Kubernetes is still operating on cgroups v1, however, it is
> possible to retrieve the task's classid based on 'current' out of
> connect(), sendmsg(), recvmsg() and bind-related hooks for orchestrators
> which attach to the root cgroup v2 hook in a mixed env like in case
> of Cilium, for example, in order to then correlate certain pod traffic
> and use it as part of the key for BPF map lookups.
>

Have you tried getting this classid directly from task_struct in your
BPF program with vmlinux.h and CO-RE? Seems like it should be pretty
straightforward and not requiring a special BPF handler just for that?

> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> ---
>  include/net/cls_cgroup.h |  7 ++++++-
>  net/core/filter.c        | 21 +++++++++++++++++++++
>  2 files changed, 27 insertions(+), 1 deletion(-)
>

[...]