netdev - Re: [PATCH V3 16/18] net: ks8851: Separate SPI operations into separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202003281038.FrT8xhjV%lkp@intel.com>
Date:   Sat, 28 Mar 2020 10:45:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Marek Vasut <marex@...x.de>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org
Subject: Re: [PATCH V3 16/18] net: ks8851: Separate SPI operations into
 separate file

Hi Marek,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on net-next/master linus/master v5.6-rc7 next-20200327]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Marek-Vasut/net-ks8851-Unify-KS8851-SPI-and-MLL-drivers/20200328-083415
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 8262e6f9b1034ede34548a04dec4c302d92c9497
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/micrel/ks8851_spi.c: In function 'ks8851_start_xmit':
>> drivers/net/ethernet/micrel/ks8851_spi.c:360:20: error: implicit declaration of function 'calc_txlen' [-Werror=implicit-function-declaration]
     360 |  unsigned needed = calc_txlen(skb->len);
         |                    ^~~~~~~~~~
>> drivers/net/ethernet/micrel/ks8851_spi.c:377:19: error: 'struct ks8851_net' has no member named 'tx_work'
     377 |  schedule_work(&ks->tx_work);
         |                   ^~
   cc1: some warnings being treated as errors

vim +/calc_txlen +360 drivers/net/ethernet/micrel/ks8851_spi.c

   343	
   344	/**
   345	 * ks8851_start_xmit - transmit packet
   346	 * @skb: The buffer to transmit
   347	 * @dev: The device used to transmit the packet.
   348	 *
   349	 * Called by the network layer to transmit the @skb. Queue the packet for
   350	 * the device and schedule the necessary work to transmit the packet when
   351	 * it is free.
   352	 *
   353	 * We do this to firstly avoid sleeping with the network device locked,
   354	 * and secondly so we can round up more than one packet to transmit which
   355	 * means we can try and avoid generating too many transmit done interrupts.
   356	 */
   357	netdev_tx_t ks8851_start_xmit(struct sk_buff *skb, struct net_device *dev)
   358	{
   359		struct ks8851_net *ks = netdev_priv(dev);
 > 360		unsigned needed = calc_txlen(skb->len);
   361		netdev_tx_t ret = NETDEV_TX_OK;
   362	
   363		netif_dbg(ks, tx_queued, ks->netdev,
   364			  "%s: skb %p, %d@%p\n", __func__, skb, skb->len, skb->data);
   365	
   366		spin_lock(&ks->statelock);
   367	
   368		if (needed > ks->tx_space) {
   369			netif_stop_queue(dev);
   370			ret = NETDEV_TX_BUSY;
   371		} else {
   372			ks->tx_space -= needed;
   373			skb_queue_tail(&ks->txq, skb);
   374		}
   375	
   376		spin_unlock(&ks->statelock);
 > 377		schedule_work(&ks->tx_work);
   378	
   379		return ret;
   380	}
   381	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (52800 bytes)