netdev - Re: [PATCH net] s390/qeth: support net namespaces for L3 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f0db28f1-d1a2-7173-1ac7-123f514768b1@linux.ibm.com>
Date:   Sat, 28 Mar 2020 11:34:07 +0100
From:   Julian Wiedmann <jwi@...ux.ibm.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        heiko.carstens@...ibm.com, ubraun@...ux.ibm.com
Subject: Re: [PATCH net] s390/qeth: support net namespaces for L3 devices

On 27.03.20 23:39, David Miller wrote:
> From: Julian Wiedmann <jwi@...ux.ibm.com>
> Date: Fri, 27 Mar 2020 12:00:42 +0100
> 
>> Enable the L3 driver's IPv4 address notifier to watch for events on qeth
>> devices that have been moved into a net namespace. We need to program
>> those IPs into the HW just as usual, otherwise inbound traffic won't
>> flow.
>>
>> Fixes: 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
>> Signed-off-by: Julian Wiedmann <jwi@...ux.ibm.com>
> 
> This looks more like a feature, openning the L3 driver into multiple
> namespaces, rather than a critical fix.
> 

Definitely not 'critical', agreed. It's rather silly though that things
currently work just fine for IPv6, but not for IPv4.

Mind queueing this up for net-next then instead? Thanks.