netdev - Re: [PATCHv3 bpf-next 0/5] Add bpf_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e58a449-16a1-0cbd-f133-7d612a82fae1@iogearbox.net>
Date:   Sat, 28 Mar 2020 18:25:34 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Joe Stringer <joe@...d.net.nz>, Martin KaFai Lau <kafai@...com>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     bpf <bpf@...r.kernel.org>, netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Lorenz Bauer <lmb@...udflare.com>
Subject: Re: [PATCHv3 bpf-next 0/5] Add bpf_sk_assign eBPF helper

On 3/27/20 10:05 PM, Joe Stringer wrote:
> On Fri, Mar 27, 2020 at 11:46 AM Martin KaFai Lau <kafai@...com> wrote:
>>
>> On Thu, Mar 26, 2020 at 09:25:51PM -0700, Joe Stringer wrote:
>>> Introduce a new helper that allows assigning a previously-found socket
>>> to the skb as the packet is received towards the stack, to cause the
[...]
>>> Changes since v1:
>>> * Replace the metadata_dst approach with using the skb->destructor to
>>>    determine whether the socket has been prefetched. This is much
>>>    simpler.
>>> * Avoid taking a reference on listener sockets during receive
>>> * Restrict assigning sockets across namespaces
>>> * Restrict assigning SO_REUSEPORT sockets
>>> * Fix cookie usage for socket dst check
>>> * Rebase the tests against test_progs infrastructure
>>> * Tidy up commit messages
>> lgtm.
>>
>> Acked-by: Martin KaFai Lau <kafai@...com>
> 
> Thanks for the reviews!
> 
> I've rolled in the current nits + acks into the branch below, pending
> any further feedback. Alexei, happy to respin this on the mailinglist
> at some point if that's easier for you.
> 
> https://github.com/joestringer/linux/tree/submit/bpf-sk-assign-v3+

Please send the updated series to the list with Martin's ACK retained, so
that we can process the series through our patchwork scripts wrt formatting,
tags etc (please also make sure it's rebased).

Thanks,
Daniel