netdev - Re: [net-next,v1] net: mscc: ocelot: add action of police on vcap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hpBfey-uWrusfDsh7oWocV-sQLBqoYGrhzYuQM8qZdegg@mail.gmail.com>
Date:   Sun, 29 Mar 2020 02:54:47 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Xiaoliang Yang <xiaoliang.yang_1@....com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Andrew Lunn <andrew@...n.ch>,
        "Allan W. Nielsen" <allan.nielsen@...rochip.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Joergen Andreasen <joergen.andreasen@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        "Y.b. Lu" <yangbo.lu@....com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Po Liu <po.liu@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Li Yang <leoyang.li@....com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [net-next,v1] net: mscc: ocelot: add action of police on vcap_is2

On Sat, 28 Mar 2020 at 15:50, Vladimir Oltean <olteanv@...il.com> wrote:
>
> Hi Xiaoliang,
>
> Thanks for the patch. I've tested it, but sadly, as-is it doesn't compile.
> But then again, net-next doesn't compile either, so there...
>
> On Sat, 28 Mar 2020 at 14:41, Xiaoliang Yang <xiaoliang.yang_1@....com> wrote:
> >
> > Ocelot has 384 policers that can be allocated to ingress ports,
> > QoS classes per port, and VCAP IS2 entries. ocelot_police.c
> > supports to set policers which can be allocated to police action
> > of VCAP IS2. We allocate policers from maximum pol_id, and
> > decrease the pol_id when add a new vcap_is2 entry which is
> > police action.
> >
> > Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@....com>
> > ---
[snip]
>
> For what it's worth, I am preparing another patch series for port
> policers in DSA, and I'm keeping your patch in my tree and rebasing on
> top of it. Depending on how things go with review, do you mind if I
> just take your patch to address other received feedback, and repost
> your flow-based policers together with my port-based policers?
>
> Regards,
> -Vladimir

I took the liberty to repost your patch with the compilation error
fixed, as part of this series:
https://patchwork.ozlabs.org/patch/1263358/

So this patch is now superseded.

Thanks,
-Vladimir