netdev - Re: [PATCH nf] netfilter: nft_exthdr: fix endianness of tcp option cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 29 Mar 2020 15:44:36 +0200
From:   Florian Westphal <fw@...len.de>
To:     Sergey Marinkevich <sergey.marinkevich@...ex-co.ru>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_exthdr: fix endianness of tcp option
 cast

Sergey Marinkevich <sergey.marinkevich@...ex-co.ru> wrote:
> I got a problem on MIPS with Big-Endian is turned on: every time when
> NF trying to change TCP MSS it returns because of new.v16 was greater
> than old.v16. But real MSS was 1460 and my rule was like this:
> 
> 	add rule table chain tcp option maxseg size set 1400
> 
> And 1400 is lesser that 1460, not greater.
> 
> Later I founded that main causer is cast from u32 to __be16.

LGTM.

Acked-by: Florian Westphal <fw@...len.de>