netdev - Re: 5.6.0-rc7+ fails to connect to wifi network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba3e6cfa-3de3-7445-f7e1-bb1a7e6e175f@googlemail.com>
Date:   Sun, 29 Mar 2020 16:49:23 +0100
From:   Chris Clayton <chris2553@...glemail.com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>, jouni@...eaurora.org,
        johannes.berg@...el.com
Subject: Re: 5.6.0-rc7+ fails to connect to wifi network



On 29/03/2020 11:54, Chris Clayton wrote:
> 
> 
> On 29/03/2020 11:06, Chris Clayton wrote:
>> Hi,
>>
>> I did a pull from Linus' tree this morning. It included the latest network fixes. Unfortunately, the resultant kernel
>> fails to connect to my home wifi network. 5.4.28 connects fine as does 5.6.0-rc7+ built at the parent commit of the
>> network merge (i.e. commit 906c40438bb669b253d0daeaf5f37a9f78a81b41 - Merge branch 'i2c/for-current' of
>> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux).
>>
>> The output from dmesg from the failed boot is attached. I've obfuscated the mac addresses of my BT router and of a
>> wifi-extender.
>>
>> Let me know if I can provide any additional diagnostics and/or test any patches.
> 
> I've bisected this and landed at:
> 
> ce2e1ca703071723ca2dd94d492a5ab6d15050da is the first bad commit
> commit ce2e1ca703071723ca2dd94d492a5ab6d15050da
> Author: Jouni Malinen <jouni@...eaurora.org>
> Date:   Thu Mar 26 15:51:34 2020 +0100
> 
>     mac80211: Check port authorization in the ieee80211_tx_dequeue() case
> 
>     mac80211 used to check port authorization in the Data frame enqueue case
>     when going through start_xmit(). However, that authorization status may
>     change while the frame is waiting in a queue. Add a similar check in the
>     dequeue case to avoid sending previously accepted frames after
>     authorization change. This provides additional protection against
>     potential leaking of frames after a station has been disconnected and
>     the keys for it are being removed.
> 
>     Cc: stable@...r.kernel.org
>     Signed-off-by: Jouni Malinen <jouni@...eaurora.org>
>     Link: https://lore.kernel.org/r/20200326155133.ced84317ea29.I34d4c47cd8cc8a4042b38a76f16a601fbcbfd9b3@changeid
>     Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> 
>  net/mac80211/tx.c | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> Jouni and Johannes added to recipients.
> 

...and reverting the change gives me working wifi again. :-)

>>
>> Please cc me in any reply as I'm not subscribed.
>>
>> Thanks.
>>