netdev - Re: issue with 85a19b0e31e2 on 4.19 -> revert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Mar 2020 17:07:10 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>, nic_swsd@...ltek.com,
        cwhuang@...roid-x86.org, netdev@...r.kernel.org
Subject: Re: issue with 85a19b0e31e2 on 4.19 -> revert

On Mon, Mar 30, 2020 at 04:39:08PM +0200, Heiner Kallweit wrote:
> On 30.03.2020 16:30, Greg Kroah-Hartman wrote:
> > On Sat, Mar 28, 2020 at 10:52:19AM +0100, Heiner Kallweit wrote:
> >> On 28.03.2020 00:24, David Miller wrote:
> >>> From: Heiner Kallweit <hkallweit1@...il.com>
> >>> Date: Sat, 28 Mar 2020 00:10:57 +0100
> >>>
> >>>> Somehow that change made it to -stable. See e.g. commit
> >>>> 85a19b0e31e256e77fd4124804b9cec10619de5e for 4.19.
> >>>
> >>> This is a serious issue in that it seems that the people maintaining
> >>> the older stable release integrate arbitrary patches even if they
> >>> haven't been sent to v5.4 and v5.5
> >>>
> >>> And I don't handle -stable backport submissions that far back anyways.
> >>>
> >>> Therefore, I'm not going to participate in that ongoing problem, so
> >>> feel free to contact the folks who integrated those changes into
> >>> -stable and ask them to revert.
> >>>
> >>> Thanks.
> >>>
> >> Greg,
> >>
> >> commit 85a19b0e31e2 ("r8169: check that Realtek PHY driver module is loaded")
> >> made it accidentally to 4.19 and causes an issue with Android/x86.
> >> Could you please revert it?
> > 
> > Now reverted.  Should I also drop this from 5.4.y and 5.5.y?
> > 
> Thanks! On 5.4 and 5.5 it's not needed to revert. The following fix from 5.6
> should make it to 5.4 and 5.5 soon.
> 
> 2e8c339b4946 ("r8169: fix PHY driver check on platforms w/o module softdeps")

I don't see it in David's queue, so I'll go take it now for those trees.

thanks,

greg k-h