netdev - Re: [PATCH net] inet_diag: add cgroup id attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Mar 2020 23:28:57 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Dmitry Yakunin <zeil@...dex-team.ru>
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net,
        netdev@...r.kernel.org, khlebnikov@...dex-team.ru
Subject: Re: [PATCH net] inet_diag: add cgroup id attribute

Hi Dmitry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on linus/master v5.6]
[cannot apply to net-next/master next-20200330]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Dmitry-Yakunin/inet_diag-add-cgroup-id-attribute/20200330-175504
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git a0ba26f37ea04e025a793ef5e5ac809221728ecb
config: mips-64r6el_defconfig (attached as .config)
compiler: mips64el-linux-gcc (GCC) 5.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=5.5.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   net/ipv4/inet_diag.c: In function 'inet_diag_msg_attrs_fill':
>> net/ipv4/inet_diag.c:166:20: error: implicit declaration of function 'sock_cgroup_ptr' [-Werror=implicit-function-declaration]
             cgroup_id(sock_cgroup_ptr(&sk->sk_cgrp_data)),
                       ^
   net/ipv4/inet_diag.c:166:20: warning: passing argument 1 of 'cgroup_id' makes pointer from integer without a cast [-Wint-conversion]
   In file included from include/net/netprio_cgroup.h:11:0,
                    from include/linux/netdevice.h:42,
                    from include/net/inet_sock.h:19,
                    from include/net/icmp.h:19,
                    from net/ipv4/inet_diag.c:18:
   include/linux/cgroup.h:308:19: note: expected 'struct cgroup *' but argument is of type 'int'
    static inline u64 cgroup_id(struct cgroup *cgrp)
                      ^
   cc1: some warnings being treated as errors

vim +/sock_cgroup_ptr +166 net/ipv4/inet_diag.c

   142	
   143		if (net_admin && nla_put_u32(skb, INET_DIAG_MARK, sk->sk_mark))
   144			goto errout;
   145	
   146		if (ext & (1 << (INET_DIAG_CLASS_ID - 1)) ||
   147		    ext & (1 << (INET_DIAG_TCLASS - 1))) {
   148			u32 classid = 0;
   149	
   150	#ifdef CONFIG_SOCK_CGROUP_DATA
   151			classid = sock_cgroup_classid(&sk->sk_cgrp_data);
   152	#endif
   153			/* Fallback to socket priority if class id isn't set.
   154			 * Classful qdiscs use it as direct reference to class.
   155			 * For cgroup2 classid is always zero.
   156			 */
   157			if (!classid)
   158				classid = sk->sk_priority;
   159	
   160			if (nla_put_u32(skb, INET_DIAG_CLASS_ID, classid))
   161				goto errout;
   162		}
   163	
   164	#ifdef CONFIG_CGROUPS
   165		if (nla_put_u64_64bit(skb, INET_DIAG_CGROUP_ID,
 > 166				      cgroup_id(sock_cgroup_ptr(&sk->sk_cgrp_data)),
   167				      INET_DIAG_PAD))
   168			goto errout;
   169	#endif
   170	
   171		r->idiag_uid = from_kuid_munged(user_ns, sock_i_uid(sk));
   172		r->idiag_inode = sock_i_ino(sk);
   173	
   174		return 0;
   175	errout:
   176		return 1;
   177	}
   178	EXPORT_SYMBOL_GPL(inet_diag_msg_attrs_fill);
   179	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (20597 bytes)