netdev - Re: [PATCH][next] net: ethernet: ti: fix spelling mistake "rundom" -> "random"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfc2cff78325ad2845ef0c7ec2d7ba719fd4f1a1.camel@perches.com>
Date:   Mon, 30 Mar 2020 10:52:09 -0700
From:   Joe Perches <joe@...ches.com>
To:     Colin King <colin.king@...onical.com>,
        "David S . Miller" <davem@...emloft.net>,
        Grygorii Strashko <grygorii.strashko@...com>,
        netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net: ethernet: ti: fix spelling mistake "rundom"
 -> "random"

On Mon, 2020-03-30 at 11:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There is a spelling mistake in a dev_err error message. Fix it.
[]
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
[]
> @@ -1627,7 +1627,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
>  							   port->slave.mac_addr) ||
>  			   !is_valid_ether_addr(port->slave.mac_addr)) {
>  			random_ether_addr(port->slave.mac_addr);
> -			dev_err(dev, "Use rundom MAC address\n");
> +			dev_err(dev, "Use random MAC address\n");

This continues without returning an error value.
Is this actually an error?

It might be useful to describe the slave and
random ethernet address too.

Perhaps:

			dev_notice(dev, "%pOF slave[%d] using random MAC address %pM\n",
				   port_np, port_id, port->slave.mac_addr);

or maybe dev_info