netdev - Re: [PATCH net-next v6 00/11] net: ethernet: ti: add networking support for k3 am65x/j721e soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Mar 2020 21:14:01 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Sekhar Nori <nsekhar@...com>, Tero Kristo <t-kristo@...com>,
        Vladimir Oltean <olteanv@...il.com>,
        David Miller <davem@...emloft.net>
CC:     <peter.ujfalusi@...com>, Rob Herring <robh@...nel.org>,
        netdev <netdev@...r.kernel.org>, <rogerq@...com>,
        <devicetree@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>,
        Murali Karicheri <m-karicheri2@...com>, <kishon@...com>,
        lkml <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>
Subject: Re: [PATCH net-next v6 00/11] net: ethernet: ti: add networking
 support for k3 am65x/j721e soc

Hi

On 30/03/2020 11:28, Sekhar Nori wrote:
> On 30/03/20 1:06 PM, Sekhar Nori wrote:
>> On 30/03/20 12:45 PM, Tero Kristo wrote:
>>> On 28/03/2020 03:53, Vladimir Oltean wrote:
>>>> Hi David,
>>>>
>>>> On Fri, 27 Mar 2020 at 05:02, David Miller <davem@...emloft.net> wrote:
>>>>>
>>>>> From: Grygorii Strashko <grygorii.strashko@...com>
>>>>> Date: Tue, 24 Mar 2020 00:52:43 +0200
>>>>>
>>>>>> This v6 series adds basic networking support support TI K3
>>>>>> AM654x/J721E SoC which
>>>>>> have integrated Gigabit Ethernet MAC (Media Access Controller) into
>>>>>> device MCU
>>>>>> domain and named MCU_CPSW0 (CPSW2G NUSS).
>>>>>    ...
>>>>>
>>>>> Series applied, thank you.
>>>>
>>>> The build is now broken on net-next:
>>>>
>>>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR
>>>> (phandle_references):
>>>> /interconnect@...000/interconnect@...80000/ethernet@...00000/ethernet-ports/port@1:
>>>>
>>>> Reference to non-existent node
>>>> or label "mcu_conf"
>>>>
>>>>     also defined at
>>>> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3
>>>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:303.23-309.6: ERROR
>>>> (phandle_references):
>>>> /interconnect@...000/interconnect@...80000/ethernet@...00000/ethernet-ports/port@1:
>>>>
>>>> Reference to non-existent node
>>>> or label "phy_gmii_sel"
>>>>
>>>>     also defined at
>>>> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:471.13-474.3
>>>>
>>>> As Grygorii said:
>>>>
>>>> Patches 1-6 are intended for netdev, Patches 7-11 are intended for K3
>>>> Platform
>>>> tree and provided here for testing purposes.
>>>
>>> Yeah, I think you are missing a dependency that was applied via the K3
>>> branch earlier. They are in linux-next now, but I am not so sure how
>>> much that is going to help you.
>>>
>>> You could just drop the DT patches from this merge and let me apply them
>>> via the platform branch.
>>
>> One other option would be that Dave merges your K3 tag which was sent to
>> ARM SoC to net-next. Its based on v5.6-rc1, has no other dependencies,
>> is already in linux-next, should be immutable and safe to merge. This
>> has the advantage that no rebase is necessary on net-next.
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/kristo/linux
>> tags/ti-k3-soc-for-v5.7
> 
> FWIW, I was able to reproduce the build failure reported by Vladimir on
> net-next, merge Tero's tag (above) cleanly into it, and see that ARM64
> defconfig build on net-next succeeds after the merge.

Thank you Sekhar for checking this.

I'm very sorry for introducing this issue. I've tried hard to avoid such issue,
but still missed it (probably I have had to drop DT patches from last submission
and send them separately).

Sorry again.

-- 
Best regards,
grygorii