netdev - Re: [PATCH net-next] mlxsw: spectrum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200330.112135.482388800634154728.davem@davemloft.net>
Date:   Mon, 30 Mar 2020 11:21:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, mlxsw@...lanox.com,
        idosch@...lanox.com
Subject: Re: [PATCH net-next] mlxsw: spectrum_ptp: Fix build warnings

From: Ido Schimmel <idosch@...sch.org>
Date: Mon, 30 Mar 2020 21:08:20 +0300

> From: Ido Schimmel <idosch@...lanox.com>
> 
> Cited commit extended the enums 'hwtstamp_tx_types' and
> 'hwtstamp_rx_filters' with values that were not accounted for in the
> switch statements, resulting in the build warnings below.
> 
> Fix by adding a default case.
> 
> drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c: In function ‘mlxsw_sp_ptp_get_message_types’:
> drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c:915:2: warning: enumeration value ‘__HWTSTAMP_TX_CNT’ not handled in switch [-Wswitch]
>   915 |  switch (tx_type) {
>       |  ^~~~~~
> drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c:927:2: warning: enumeration value ‘__HWTSTAMP_FILTER_CNT’ not handled in switch [-Wswitch]
>   927 |  switch (rx_filter) {
>       |  ^~~~~~
> 
> Fixes: f76510b458a5 ("ethtool: add timestamping related string sets")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: David S. Miller <davem@...emloft.net>

Applied, thanks.