netdev - Re: [PATCH net-next] bpf: tcp: Fix unused-function warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78e91a32-a329-122d-1fcf-25d2a026180d@iogearbox.net>
Date:   Mon, 30 Mar 2020 23:05:04 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH net-next] bpf: tcp: Fix unused-function warnings

On 3/30/20 9:49 AM, Saeed Mahameed wrote:
> tcp_bpf_sendpage, tcp_bpf_sendmsg, tcp_bpf_send_verdict and
> tcp_bpf_stream_read are only used when CONFIG_BPF_STREAM_PARSER is ON,
> make sure they are defined under this flag as well.
> 
> Fixed compiler warnings:
> 
> net/ipv4/tcp_bpf.c:483:12:
> warning: ‘tcp_bpf_sendpage’ defined but not used [-Wunused-function]
>   static int tcp_bpf_sendpage(struct sock *sk, struct page *page, ...
>              ^~~~~~~~~~~~~~~~
> net/ipv4/tcp_bpf.c:395:12:
> warning: ‘tcp_bpf_sendmsg’ defined but not used [-Wunused-function]
>   static int tcp_bpf_sendmsg(struct sock *sk, struct msghdr, ...
>              ^~~~~~~~~~~~~~~
> net/ipv4/tcp_bpf.c:13:13:
> warning: ‘tcp_bpf_stream_read’ defined but not used [-Wunused-function]
>   static bool tcp_bpf_stream_read(const struct sock *sk)
> 
> Fixes: 604326b41a6f ("bpf, sockmap: convert to generic sk_msg interface")
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: John Fastabend <john.fastabend@...il.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
Already fixed here, PR for bpf-next will go out today:

https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=a26527981af2988ae0f17f6d633848c019929e38

Thanks,
Daniel