netdev - Re: [PATCH net-next v3 03/15] netdevsim: Add devlink-trap policer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200330161749.72ff0309@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 30 Mar 2020 16:17:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next v3 03/15] netdevsim: Add devlink-trap policer
 support

On Mon, 30 Mar 2020 22:38:20 +0300 Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...lanox.com>
> 
> Register three dummy packet trap policers with devlink and implement
> callbacks to change their parameters and read their counters.
> 
> This will be used later on in the series to test the devlink-trap
> policer infrastructure.
> 
> v2:
> * Remove check about burst size being a power of 2 and instead add a
>   debugfs knob to fail the operation
> * Provide max/min rate/burst size when registering policers and remove
>   the validity checks from nsim_dev_devlink_trap_policer_set()
> 
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>