netdev - Re: [PATCH v2 net-next] qed: Fix race condition between scheduling and destroying the slowpath workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200329.215039.1358234093708415942.davem@davemloft.net>
Date:   Sun, 29 Mar 2020 21:50:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ybason@...vell.com
Cc:     netdev@...r.kernel.org, dbolotin@...vell.com, mkalderon@...vell.com
Subject: Re: [PATCH v2 net-next] qed: Fix race condition between scheduling
 and destroying the slowpath workqueue

From: Yuval Basson <ybason@...vell.com>
Date: Wed, 25 Mar 2020 22:50:43 +0200

> Calling queue_delayed_work concurrently with
> destroy_workqueue might race to an unexpected outcome -
> scheduled task after wq is destroyed or other resources
> (like ptt_pool) are freed (yields NULL pointer dereference).
> cancel_delayed_work prevents the race by cancelling
> the timer triggered for scheduling a new task.
> 
> Fixes: 59ccf86fe ("qed: Add driver infrastucture for handling mfw requests")
> Signed-off-by: Denis Bolotin <dbolotin@...vell.com>
> Signed-off-by: Michal Kalderon <mkalderon@...vell.com>
> Signed-off-by: Yuval Basson <ybason@...vell.com>

Applied.