netdev - Re: [PATCH net-next] neigh: support smaller retrans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200331.095406.351446411247167894.davem@davemloft.net>
Date:   Tue, 31 Mar 2020 09:54:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] neigh: support smaller retrans_time settting

From: Hangbin Liu <liuhangbin@...il.com>
Date: Tue, 31 Mar 2020 11:33:56 +0800

> Currently, we limited the retrans_time to be greater than HZ/2. For
> example, if the HZ = 1000, setting retrans_time less than 500ms will
> not work. This makes the user unable to achieve a more accurate control
> for bonding arp fast failover.
> 
> But remove the sanity check would make the retransmission immediately
> if user set retrans_time to 0 by wrong config. So I hard code the sanity
> check to 10, which is 10ms if HZ is 1000 and 100ms if HZ is 100.
> This number should be enough for user to get more accurate neigh
> control.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

It only makes sense to make the safety limit be constant (time wise),
and therefore relative to HZ.