netdev - Re: [PATCH net-next] net: dsa: fix oops while probing Marvell DSA switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200331130042.GB1403168@t480s.localdomain>
Date:   Tue, 31 Mar 2020 13:00:42 -0400
From:   Vivien Didelot <vivien.didelot@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>, ioana.ciornei@....com,
        olteanv@...il.com, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: fix oops while probing Marvell DSA
 switches

On Tue, 31 Mar 2020 15:17:36 +0100, Russell King <rmk+kernel@...linux.org.uk> wrote:
> Fix an oops in dsa_port_phylink_mac_change() caused by a combination
> of a20f997010c4 ("net: dsa: Don't instantiate phylink for CPU/DSA
> ports unless needed") and the net-dsa-improve-serdes-integration
> series of patches 65b7a2c8e369 ("Merge branch
> 'net-dsa-improve-serdes-integration'").
> 
> Unable to handle kernel NULL pointer dereference at virtual address 00000124
> pgd = c0004000
> [00000124] *pgd=00000000
> Internal error: Oops: 805 [#1] SMP ARM
> Modules linked in: tag_edsa spi_nor mtd xhci_plat_hcd mv88e6xxx(+) xhci_hcd armada_thermal marvell_cesa dsa_core ehci_orion libdes phy_armada38x_comphy at24 mcp3021 sfp evbug spi_orion sff mdio_i2c
> CPU: 1 PID: 214 Comm: irq/55-mv88e6xx Not tainted 5.6.0+ #470
> Hardware name: Marvell Armada 380/385 (Device Tree)
> PC is at phylink_mac_change+0x10/0x88
> LR is at mv88e6352_serdes_irq_status+0x74/0x94 [mv88e6xxx]
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Vivien Didelot <vivien.didelot@...il.com>