netdev - Re: [PATCH net] cxgb4: fix MPS index overwrite when setting MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200401.111930.504991135006095672.davem@davemloft.net>
Date:   Wed, 01 Apr 2020 11:19:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rahul.lakkireddy@...lsio.com
Cc:     netdev@...r.kernel.org, herat@...lsio.com, nirranjan@...lsio.com,
        vishal@...lsio.com, dt@...lsio.com
Subject: Re: [PATCH net] cxgb4: fix MPS index overwrite when setting MAC
 address

From: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Date: Wed,  1 Apr 2020 01:16:09 +0530

> From: Herat Ramani <herat@...lsio.com>
> 
> cxgb4_update_mac_filt() earlier requests firmware to add a new MAC
> address into MPS TCAM. The MPS TCAM index returned by firmware is
> stored in pi->xact_addr_filt. However, the saved MPS TCAM index gets
> overwritten again with the return value of cxgb4_update_mac_filt(),
> which is wrong.
> 
> When trying to update to another MAC address later, the wrong MPS TCAM
> index is sent to firmware, which causes firmware to return error,
> because it's not the same MPS TCAM index that firmware had sent
> earlier to driver.
> 
> So, fix by removing the wrong overwrite being done after call to
> cxgb4_update_mac_filt().
> 
> Fixes: 3f8cfd0d95e6 ("cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()")
> Signed-off-by: Herat Ramani <herat@...lsio.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>

Applied and queued up for -stable.