| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 Apr 2020 12:45:09 -0700 From: Gregory Rose <gvrose8192@...il.com> To: xiangxia.m.yue@...il.com, pshelar@....org Cc: dev@...nvswitch.org, netdev@...r.kernel.org Subject: Re: [ovs-dev] [PATCH] net: openvswitch: use hlist_for_each_entry_rcu instead of hlist_for_each_entry On 3/25/2020 1:27 PM, xiangxia.m.yue@...il.com wrote: > From: Tonghao Zhang <xiangxia.m.yue@...il.com> > > The struct sw_flow is protected by RCU, when traversing them, > use hlist_for_each_entry_rcu. > > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com> > --- > net/openvswitch/flow_table.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c > index fd8a01c..b7b5744 100644 > --- a/net/openvswitch/flow_table.c > +++ b/net/openvswitch/flow_table.c > @@ -462,12 +462,14 @@ static void flow_table_copy_flows(struct table_instance *old, > struct hlist_head *head = &old->buckets[i]; > > if (ufid) > - hlist_for_each_entry(flow, head, > - ufid_table.node[old_ver]) > + hlist_for_each_entry_rcu(flow, head, > + ufid_table.node[old_ver], > + lockdep_ovsl_is_held()) > ufid_table_instance_insert(new, flow); > else > - hlist_for_each_entry(flow, head, > - flow_table.node[old_ver]) > + hlist_for_each_entry_rcu(flow, head, > + flow_table.node[old_ver], > + lockdep_ovsl_is_held()) > table_instance_insert(new, flow); > } > > Applies cleanly and compile test passes. Passes openvswitch kernel testsuite. Code looks fine to me. Tested-by: Greg Rose <gvrose8192@...il.com> Reviewed-by: Greg Rose <gvrose8192@...il.com>
Powered by blists - more mailing lists