netdev - Re: [PATCH bpf] riscv: remove BPF JIT for nommu builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92890a1f-12d6-6505-c3a9-60cf9753dc2b@iogearbox.net>
Date:   Fri, 3 Apr 2020 00:51:25 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Björn Töpel <bjorn.topel@...il.com>,
        netdev@...r.kernel.org, bpf@...r.kernel.org, ast@...nel.org
Cc:     linux-riscv@...ts.infradead.org, Damien.LeMoal@....com,
        hch@...radead.org, kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH bpf] riscv: remove BPF JIT for nommu builds

On 3/31/20 12:10 PM, Björn Töpel wrote:
> The BPF JIT fails to build for kernels configured to !MMU. Without an
> MMU, the BPF JIT does not make much sense, therefore this patch
> disables the JIT for nommu builds.
> 
> This was reported by the kbuild test robot:
> 
>     All errors (new ones prefixed by >>):
> 
>        arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_jit_alloc_exec':
>     >> arch/riscv/net/bpf_jit_comp64.c:1094:47: error: 'BPF_JIT_REGION_START' undeclared (first use in this function)
>         1094 |  return __vmalloc_node_range(size, PAGE_SIZE, BPF_JIT_REGION_START,
>              |                                               ^~~~~~~~~~~~~~~~~~~~
>        arch/riscv/net/bpf_jit_comp64.c:1094:47: note: each undeclared identifier is reported only once for each function it appears in
>     >> arch/riscv/net/bpf_jit_comp64.c:1095:9: error: 'BPF_JIT_REGION_END' undeclared (first use in this function)
>         1095 |         BPF_JIT_REGION_END, GFP_KERNEL,
>              |         ^~~~~~~~~~~~~~~~~~
>        arch/riscv/net/bpf_jit_comp64.c:1098:1: warning: control reaches end of non-void function [-Wreturn-type]
>         1098 | }
>              | ^
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Björn Töpel <bjorn.topel@...il.com>

Applied, thanks!