netdev - Re: [PATCH] net/faraday: fix grammar in function ftgmac100_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d146a02d-372e-0f54-39e7-3ebcd0c46e4f@163.com>
Date:   Thu, 2 Apr 2020 19:13:15 +0800
From:   Hu Haowen <xianfengting221@....com>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        davem@...emloft.net, andrew@...n.ch, mchehab+samsung@...nel.org,
        andrew@...id.au, corbet@....net
Cc:     stfrench@...rosoft.com, chris@...is-wilson.co.uk,
        xiubli@...hat.com, airlied@...hat.com, tglx@...utronix.de,
        hkallweit1@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/faraday: fix grammar in function
 ftgmac100_setup_clk() in ftgmac100.c


On 2020/4/2 6:43 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2020-04-01 at 18:56 +0800, Hu Haowen wrote:
>> "its not" is wrong. The words should be "it's not".
>>
>> Signed-off-by: Hu Haowen <xianfengting221@....com>
> Typo more than grammer :-)


Emm...


In fact I just found the mistake by accident and decided to fix it up
because it is a standard in the kernel documention not to misspell
words :-)


>
> Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>
>   (the offender)
>
>> ---
>>   drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
>> index 835b7816e372..87236206366f 100644
>> --- a/drivers/net/ethernet/faraday/ftgmac100.c
>> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
>> @@ -1731,7 +1731,7 @@ static int ftgmac100_setup_clk(struct ftgmac100 *priv)
>>   	if (rc)
>>   		goto cleanup_clk;
>>   
>> -	/* RCLK is for RMII, typically used for NCSI. Optional because its not
>> +	/* RCLK is for RMII, typically used for NCSI. Optional because it's not
>>   	 * necessary if it's the AST2400 MAC, or the MAC is configured for
>>   	 * RGMII, or the controller is not an ASPEED-based controller.
>>   	 */