netdev - RE: [EXT] [PATCH][next] net: atlantic: fix missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR18MB14189BD4043BE8974C9AC001B7C60@DM5PR18MB1418.namprd18.prod.outlook.com>
Date:   Thu, 2 Apr 2020 11:40:06 +0000
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Colin King <colin.king@...onical.com>,
        "David S . Miller" <davem@...emloft.net>,
        Mark Starovoytov <mstarovoitov@...vell.com>,
        "Dmitry Bogdanov" <dbogdanov@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH][next] net: atlantic: fix missing | operator when
 assigning rec->llc

Thanks Colin,

We also found this typo recently, but you were ahead of us )

> From: Colin Ian King <colin.king@...onical.com>
> rec->llc is currently being assigned twice, once with the lower 8 bits
> from packed_record[8] and then re-assigned afterwards with data from packed_record[9].  This looks like a type,
>  I believe the second assignment should be using the |= operator rather than a direct assignment.

> Addresses-Coverity: ("Unused value")
> Fixes: b8f8a0b7b5cb ("net: atlantic: MACSec ingress offload HW bindings")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Igor Russkikh <irusskikh@...ell.com>