netdev - Re: [PATCH net] crypto: chtls - Fix build error without IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200402.065446.2295152097236024797.davem@davemloft.net>
Date:   Thu, 02 Apr 2020 06:54:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     ayush.sawal@...lsio.com, vinay.yadav@...lsio.com,
        rohitm@...lsio.com, herbert@...dor.apana.org.au,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] crypto: chtls - Fix build error without IPV6

From: YueHaibing <yuehaibing@...wei.com>
Date: Thu, 2 Apr 2020 09:43:23 +0800

> If IPV6 is not set, build fails:
> 
> drivers/crypto/chelsio/chcr_ktls.c: In function ‘chcr_ktls_act_open_req6’:
> ./include/net/sock.h:380:37: error: ‘struct sock_common’ has no member named ‘skc_v6_rcv_saddr’; did you mean ‘skc_rcv_saddr’?
>  #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
>                                      ^
> drivers/crypto/chelsio/chcr_ktls.c:258:37: note: in expansion of macro ‘sk_v6_rcv_saddr’
>   cpl->local_ip_hi = *(__be64 *)&sk->sk_v6_rcv_saddr.in6_u.u6_addr8[0];
>                                      ^~~~~~~~~~~~~~~
> 
> Add IPV6 dependency to fix this.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 62370a4f346d ("cxgb4/chcr: Add ipv6 support and statistics")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

This is a hard hammer, and I think proper CPP testing should be added to the
driver code instead.