netdev - Re: [PATCH v3 net] inet_diag: add cgroup id attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200403.160809.1500394661848619682.davem@davemloft.net>
Date:   Fri, 03 Apr 2020 16:08:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zeil@...dex-team.ru
Cc:     netdev@...r.kernel.org, khlebnikov@...dex-team.ru,
        cgroups@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH v3 net] inet_diag: add cgroup id attribute

From: Dmitry Yakunin <zeil@...dex-team.ru>
Date: Fri, 3 Apr 2020 12:56:27 +0300

> This patch adds cgroup v2 ID to common inet diag message attributes.
> Cgroup v2 ID is kernfs ID (ino or ino+gen). This attribute allows filter
> inet diag output by cgroup ID obtained by name_to_handle_at() syscall.
> When net_cls or net_prio cgroup is activated this ID is equal to 1 (root
> cgroup ID) for newly created sockets.
> 
> Some notes about this ID:
> 
> 1) gets initialized in socket() syscall
> 2) incoming socket gets ID from listening socket
>    (not during accept() syscall)
> 3) not changed when process get moved to another cgroup
> 4) can point to deleted cgroup (refcounting)
> 
> v2:
>   - use CONFIG_SOCK_CGROUP_DATA instead if CONFIG_CGROUPS
> 
> v3:
>   - fix attr size by using nla_total_size_64bit() (Eric Dumazet)
>   - more detailed commit message (Konstantin Khlebnikov)
> 
> Signed-off-by: Dmitry Yakunin <zeil@...dex-team.ru>
> Reviewed-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>

As a new feature, this should be resubmitted when net-next opens back
up.  Thank you.