netdev - Re: [PATCH] net/mlx5: improve some comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e7e26f7ef453268b7662f96ad3772ca3bbd7cd2.camel@mellanox.com>
Date:   Fri, 3 Apr 2020 02:33:58 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "xianfengting221@....com" <xianfengting221@....com>,
        "leon@...nel.org" <leon@...nel.org>
CC:     "cai@....pw" <cai@....pw>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "stfrench@...rosoft.com" <stfrench@...rosoft.com>,
        "xiubli@...hat.com" <xiubli@...hat.com>,
        "guoren@...nel.org" <guoren@...nel.org>,
        "jeyu@...nel.org" <jeyu@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "wqu@...e.com" <wqu@...e.com>,
        "chris@...is-wilson.co.uk" <chris@...is-wilson.co.uk>,
        "yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net/mlx5: improve some comments

On Wed, 2020-04-01 at 21:14 +0800, Hu Haowen wrote:
> On 2020/4/1 8:57 PM, Hu Haowen wrote:
> > Added a missing space character and replaced "its" with "it's".
> 
> Sorry, this patch does not include space character adding. Please
> ignore and delete that part of the commit message.
> 

Hi, 

Thanks for the patch I will apply and fix the commit message. BUT..
net-next is closed and the rules apply to everyone, even mlx5 branch,
so please for next time, let's wait for net-next to open.

Thanks,
Saeed.

> 
> > Signed-off-by: Hu Haowen <xianfengting221@....com>
> > ---
> >   drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > index c9c9b479bda5..0a8adda073c2 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > @@ -684,7 +684,7 @@ static void mlx5_fw_tracer_handle_traces(struct
> > work_struct *work)
> >   		get_block_timestamp(tracer,
> > &tmp_trace_block[TRACES_PER_BLOCK - 1]);
> >   
> >   	while (block_timestamp > tracer->last_timestamp) {
> > -		/* Check block override if its not the first block */
> > +		/* Check block override if it's not the first block */
> >   		if (!tracer->last_timestamp) {
> >   			u64 *ts_event;
> >   			/* To avoid block override be the HW in case of
> > buffer