netdev - Re: question about drivers/net/dsa/sja1105/sja1105

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 4 Apr 2020 11:37:45 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Julia Lawall <julia.lawall@...ia.fr>,
        netdev <netdev@...r.kernel.org>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: question about drivers/net/dsa/sja1105/sja1105_main.c

On Sat, 4 Apr 2020 at 00:12, Joe Perches <joe@...ches.com> wrote:
>
> On Fri, 2020-04-03 at 23:02 +0200, Heiner Kallweit wrote:
> > It's right that this is not correct. You can check genphy_read_status_fixed()
> > for how it's done there.
>
> There is no SPEED_UNKNOWN in that function.
>
>

Correct, there isn't.
The bitwise value of the 2 speed bits from MII_BMCR is:
Bits [6,13]:
1 1 = Reserved
1 0 = 1000 Mbps
0 1 = 100 Mbps
0 0 = 10 Mbps
So basically the PHY library assumes that no piece of hardware will
ever set the speed bits to 11, as that would invalidate the spec.

-Vladimir