netdev - Re: [PATCH net] ipv6: rpl: fix loop iteration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200406.100606.1382059106426370272.davem@davemloft.net>
Date:   Mon, 06 Apr 2020 10:06:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alex.aring@...il.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, kuba@...nel.org,
        mcr@...delman.ca, stefan@...enfreihafen.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv6: rpl: fix loop iteration

From: Alexander Aring <alex.aring@...il.com>
Date: Sat,  4 Apr 2020 11:22:57 -0400

> This patch fix the loop iteration by not walking over the last
> iteration. The cmpri compressing value exempt the last segment. As the
> code shows the last iteration will be overwritten by cmpre value
> handling which is for the last segment.
> 
> I think this doesn't end in any bufferoverflows because we work on worst
> case temporary buffer sizes but it ends in not best compression settings
> in some cases.
> 
> Fixes: 8610c7c6e3bd ("net: ipv6: add support for rpl sr exthdr")
> Signed-off-by: Alexander Aring <alex.aring@...il.com>

Applied, thanks.