netdev - Re: [PATCH net 5.7] r8169: change back SG and TSO to be disabled by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200406.101220.600419687722951897.davem@davemloft.net>
Date:   Mon, 06 Apr 2020 10:12:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net 5.7] r8169: change back SG and TSO to be disabled
 by default

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sat, 4 Apr 2020 23:52:25 +0200

> There has been a number of reports that using SG/TSO on different chip
> versions results in tx timeouts. However for a lot of people SG/TSO
> works fine. Therefore disable both features by default, but allow users
> to enable them. Use at own risk!
> 
> Fixes: 93681cd7d94f ("r8169: enable HW csum and TSO")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

It's unfortunate we have to do this, but better safe than sorry.

Applied and queued up for -stable, and thanks for the backport.