netdev - Re: [PATCH net] macsec: fix NULL dereference in macsec_upd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200406.102624.1004066216541067473.davem@davemloft.net>
Date:   Mon, 06 Apr 2020 10:26:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     antoine.tenart@...tlin.com, dbogdanov@...vell.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] macsec: fix NULL dereference in
 macsec_upd_offload()

From: Davide Caratti <dcaratti@...hat.com>
Date: Mon,  6 Apr 2020 11:38:29 +0200

> macsec_upd_offload() gets the value of MACSEC_OFFLOAD_ATTR_TYPE
> without checking its presence in the request message, and this causes
> a NULL dereference. Fix it rejecting any configuration that does not
> include this attribute.
> 
> Reported-and-tested-by: syzbot+7022ab7c383875c17eff@...kaller.appspotmail.com
> Fixes: dcb780fb2795 ("net: macsec: add nla support for changing the offloading selection")
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied.