[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200406180635.GC2354@nanopsycho.orion>
Date: Mon, 6 Apr 2020 20:06:35 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org, dsahern@...il.com, mlxsw@...lanox.com
Subject: Re: [patch iproute2/net-next 8/8] man: add man page for devlink dpipe
Mon, Apr 06, 2020 at 07:30:36PM CEST, stephen@...workplumber.org wrote:
>On Sat, 4 Apr 2020 18:16:21 +0200
>Jiri Pirko <jiri@...nulli.us> wrote:
>
>> From: Jiri Pirko <jiri@...lanox.com>
>>
>> Add simple man page for devlink dpipe.
>>
>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>> ---
>> man/man8/devlink-dpipe.8 | 100 +++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 100 insertions(+)
>> create mode 100644 man/man8/devlink-dpipe.8
>>
>> diff --git a/man/man8/devlink-dpipe.8 b/man/man8/devlink-dpipe.8
>> new file mode 100644
>> index 000000000000..00379401208e
>> --- /dev/null
>> +++ b/man/man8/devlink-dpipe.8
>> @@ -0,0 +1,100 @@
>> +.TH DEVLINK\-DPIPE 8 "4 Apr 2020" "iproute2" "Linux"
>> +.SH NAME
>> +devlink-dpipe \- devlink dataplane pipeline visualization
>> +.SH SYNOPSIS
>> +.sp
>> +.ad l
>> +.in +8
>> +.ti -8
>> +.B devlink
>> +.RI "[ " OPTIONS " ]"
>> +.B dpipe
>> +.RB "{ " table " | " header " }"
>> +.RI "{ " COMMAND " | "
>> +.BR help " }"
>> +.sp
>> +
>> +.ti -8
>> +.IR OPTIONS " := { "
>> +\fB\-V\fR[\fIersion\fR] }
>> +
>> +.ti -8
>> +.BI "devlink dpipe table show " DEV
>> +.R [
>> +.BI name " TABLE_NAME "
>> +.R ]
>
>I applied the whole set, but fixed some issues on the man page.
>You had some trailing white space, and the .R macro is not the right
>way to do this. Make check runs a script from Debian and it spots that.
Okay. I'll make sure to run this next time. I had no idea it checkes
man. Thanks!
Powered by blists - more mailing lists