netdev - RE: [PATCH net] skbuff.h: Improve the checksum related comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Apr 2020 01:25:29 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Matthew Wilcox <willy@...radead.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "willemb@...gle.com" <willemb@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "simon.horman@...ronome.com" <simon.horman@...ronome.com>,
        "sdf@...gle.com" <sdf@...gle.com>,
        "john.hurley@...ronome.com" <john.hurley@...ronome.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "fw@...len.de" <fw@...len.de>,
        "jonathan.lemon@...il.com" <jonathan.lemon@...il.com>,
        "pablo@...filter.org" <pablo@...filter.org>,
        "jeremy@...zel.net" <jeremy@...zel.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net] skbuff.h: Improve the checksum related comments

> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: Sunday, April 5, 2020 9:41 AM
> To: Dexuan Cui <decui@...rosoft.com>; Matthew Wilcox
> >> Why the capitalisation of 'AND'?
> > ...
> > The comma after the "CHECKSUM_PARTIAL" seems suspicious to me. I feel
> > we should add an "and" after the comma, or replace the comma with "and",
> > but either way we'll have "... and csum_start and csum_offset...", which 
> > seems a little unnatural to me since we have 2 'and's here... So I tried to 
> > make it a little natural by replacing the first 'and' with 'AND', which 
> > obviously causes confusion to you.
> 
> maybe "both csum_start and csum_offset are set to refer to".
> ~Randy

Looks good. I'll post a v2 shortly. Thank you both!

Thanks,
-- Dexuan