netdev - Re: [PATCH v2 net] skbuff.h: Improve the checksum related comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6efee6bb-d68d-0f83-d469-b173cf4f5d0f@infradead.org>
Date:   Sun, 5 Apr 2020 18:42:33 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     decui@...rosoft.com, willy@...radead.org, netdev@...r.kernel.org,
        davem@...emloft.net, willemb@...gle.com, kuba@...nel.org,
        simon.horman@...ronome.com, sdf@...gle.com, edumazet@...gle.com,
        fw@...len.de, jonathan.lemon@...il.com, pablo@...filter.org,
        jeremy@...zel.net, pabeni@...hat.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] skbuff.h: Improve the checksum related comments

On 4/5/20 6:26 PM, Dexuan Cui wrote:
> @@ -211,9 +211,9 @@
>   * is implied by the SKB_GSO_* flags in gso_type. Most obviously, if the
>   * gso_type is SKB_GSO_TCPV4 or SKB_GSO_TCPV6, TCP checksum offload as
>   * part of the GSO operation is implied. If a checksum is being offloaded
> - * with GSO then ip_summed is CHECKSUM_PARTIAL, csum_start and csum_offset
> - * are set to refer to the outermost checksum being offload (two offloaded
> - * checksums are possible with UDP encapsulation).
> + * with GSO then ip_summed is CHECKSUM_PARTIAL, and both csum_start and
> + * csum_offset are set to refer to the outermost checksum being offload (two

                                                             being offloaded

> + * offloaded checksums are possible with UDP encapsulation).
>   */
>  
>  /* Don't change this without changing skb_csum_unnecessary! */


Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.
-- 
~Randy