netdev - Re: [PATCH] mac80211: fix race in ieee80211_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee168acb768d87776db2be4e978616f9187908d0.camel@sipsolutions.net>
Date:   Mon, 06 Apr 2020 15:07:57 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     Sumit Garg <sumit.garg@...aro.org>, linux-wireless@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, matthias.schoepfer@...inx.io,
        Philipp.Berg@...bherr.com, Michael.Weitner@...bherr.com,
        daniel.thompson@...aro.org, loic.poulain@...aro.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] mac80211: fix race in ieee80211_register_hw()

On Mon, 2020-04-06 at 16:04 +0300, Kalle Valo wrote:
> Johannes Berg <johannes@...solutions.net> writes:
> 
> > On Mon, 2020-04-06 at 15:52 +0300, Kalle Valo wrote:
> > > Johannes Berg <johannes@...solutions.net> writes:
> > > 
> > > > On Mon, 2020-04-06 at 15:44 +0300, Kalle Valo wrote:
> > > > > >     user-space  ieee80211_register_hw()  RX IRQ
> > > > > >     +++++++++++++++++++++++++++++++++++++++++++++
> > > > > >        |                    |             |
> > > > > >        |<---wlan0---wiphy_register()      |
> > > > > >        |----start wlan0---->|             |
> > > > > >        |                    |<---IRQ---(RX packet)
> > > > > >        |              Kernel crash        |
> > > > > >        |              due to unallocated  |
> > > > > >        |              workqueue.          |
> > > > 
> > > > [snip]
> > > > 
> > > > > I have understood that no frames should be received until mac80211 calls
> > > > > struct ieee80211_ops::start:
> > > > > 
> > > > >  * @start: Called before the first netdevice attached to the hardware
> > > > >  *         is enabled. This should turn on the hardware and must turn on
> > > > >  *         frame reception (for possibly enabled monitor interfaces.)
> > > > 
> > > > True, but I think he's saying that you can actually add and configure an
> > > > interface as soon as the wiphy is registered?
> > > 
> > > With '<---IRQ---(RX packet)' I assumed wcn36xx is delivering a frame to
> > > mac80211 using ieee80211_rx(), but of course I'm just guessing here.
> > 
> > Yeah, but that could be legitimate?
> 
> Ah, I misunderstood then. The way I have understood is that no rx frames
> should be delivered (= calling ieee80211_rx()_ before start() is called,
> but if that's not the case please ignore me :)

No no, that _is_ the case. But I think the "start wlan0" could end up
calling it?

johannes