netdev - Re: [PATCH 1/5] ath9k: Fix use-after-free Read in htc_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200407105154.GI2001@kadam>
Date:   Tue, 7 Apr 2020 13:51:55 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Qiujun Huang <hqjagain@...il.com>
Cc:     kvalo@...eaurora.org, ath9k-devel@....qualcomm.com,
        davem@...emloft.net, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        anenbupt@...il.com, syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH 1/5] ath9k: Fix use-after-free Read in htc_connect_service

This patch is correct but there are a lot of error paths in
hif_usb_send() which don't free the skb.  Some error paths *do* free
the skb but most don't.  It's really a lot of work to sort through and
fix.

regards,
dan carpenter