netdev - Re: [PATCH] qtnfmac: Simplify code in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200407194812.aziu2hedsfkwh7lg@bars>
Date:   Tue, 7 Apr 2020 22:48:13 +0300
From:   Sergey Matyukevich <sergey.matyukevich.os@...ntenna.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC:     imitsyanko@...ntenna.com, avinashp@...ntenna.com,
        smatyukevich@...ntenna.com, kvalo@...eaurora.org,
        davem@...emloft.net, huangfq.daxian@...il.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] qtnfmac: Simplify code in _attach functions


Hello Christophe,

> There is no need to re-implement 'netdev_alloc_skb_ip_align()' here.
> Keep the code simple.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Thanks for cleaning this up!

Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@...ntenna.com>

Regards,
Sergey