netdev - Re: [PATCH] ath11k: thermal: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c636eaf-7672-353c-80b2-1649b3a94e60@huawei.com>
Date:   Tue, 7 Apr 2020 10:01:47 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     Kalle Valo <kvalo@...eaurora.org>
CC:     <davem@...emloft.net>, <pradeepc@...eaurora.org>,
        <netdev@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
        <ath11k@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ath11k: thermal: Fix build error without CONFIG_THERMAL

On 2020/4/6 21:02, Kalle Valo wrote:
> YueHaibing <yuehaibing@...wei.com> writes:
> 
>> drivers/net/wireless/ath/ath11k/thermal.h:45:1:
>>  warning: no return statement in function returning non-void [-Wreturn-type]
>> drivers/net/wireless/ath/ath11k/core.c:416:28: error:
>>  passing argument 1 of ‘ath11k_thermal_unregister’ from incompatible pointer type [-Werror=incompatible-pointer-types]
>>
>> Add missing return 0 in ath11k_thermal_set_throttling,
>> and fix ath11k_thermal_unregister param type.
> 
> These are warnings, no? "build error" and "compiler warning" are
> different things, the former breaks the whole build which is super
> critical, but I'll queue this to v5.7 nevertheless. And I'll change the
> title to:
> 
> ath11k: fix compiler warning without CONFIG_THERMAL

Ok , thanks!

>