netdev - Re: [PATCH net] net: sched: Fix setting last executed chain on skb extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200407.183311.1429584861130475659.davem@davemloft.net>
Date:   Tue, 07 Apr 2020 18:33:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     paulb@...lanox.com
Cc:     ozsh@...lanox.com, roid@...lanox.com, netdev@...r.kernel.org,
        jiri@...lanox.com, saeedm@...lanox.com, xiyou.wangcong@...il.com,
        jhs@...atatu.com, kuba@...nel.org
Subject: Re: [PATCH net] net: sched: Fix setting last executed chain on skb
 extension

From: Paul Blakey <paulb@...lanox.com>
Date: Mon,  6 Apr 2020 18:36:56 +0300

> After driver sets the missed chain on the tc skb extension it is
> consumed (deleted) by tc_classify_ingress and tc jumps to that chain.
> If tc now misses on this chain (either no match, or no goto action),
> then last executed chain remains 0, and the skb extension is not re-added,
> and the next datapath (ovs) will start from 0.
> 
> Fix that by setting last executed chain to the chain read from the skb
> extension, so if there is a miss, we set it back.
> 
> Fixes: af699626ee26 ("net: sched: Support specifying a starting chain via tc skb ext")
> Reviewed-by: Oz Shlomo <ozsh@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Paul Blakey <paulb@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>

Applied, thank you.