netdev - Re: [PATCH RFC v2 00/33] XDP extend with knowledge of frame size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200408165519.da6dr5mclqol6g26@ast-mbp>
Date:   Wed, 8 Apr 2020 09:55:19 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     sameehj@...zon.com, Grygorii Strashko <grygorii.strashko@...com>,
        intel-wired-lan@...ts.osuosl.org, Ariel Elior <aelior@...vell.com>,
        Andy Gospodarek <gospo@...adcom.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Jason Wang <jasowang@...hat.com>,
        Sunil Goutham <sgoutham@...vell.com>,
        Robert Richter <rrichter@...vell.com>,
        GR-everest-linux-l2@...vell.com, Wei Liu <wei.liu@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Arthur Kiyanovski <akiyano@...zon.com>,
        Ioana Radulescu <ruxandra.radulescu@....com>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Mao Wenan <maowenan@...wei.com>,
        Toshiaki Makita <toshiaki.makita1@...il.com>,
        Michael Chan <michael.chan@...adcom.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Andy Gospodarek <andrew.gospodarek@...adcom.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        thomas.petazzoni@...tlin.com, netdev@...r.kernel.org,
        bpf@...r.kernel.org, zorik@...zon.com, gtzalik@...zon.com,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        David Ahern <dsahern@...il.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH RFC v2 00/33] XDP extend with knowledge of frame size

On Wed, Apr 08, 2020 at 01:50:34PM +0200, Jesper Dangaard Brouer wrote:
> RFC-note: This is only an RFC because net-next is closed.
> - Please ACK patches you like, then I will collect those for later.
> 
> XDP have evolved to support several frame sizes, but xdp_buff was not
> updated with this information. This have caused the side-effect that
> XDP frame data hard end is unknown. This have limited the BPF-helper
> bpf_xdp_adjust_tail to only shrink the packet. This patchset address
> this and add packet tail extend/grow.
> 
> The purpose of the patchset is ALSO to reserve a memory area that can be
> used for storing extra information, specifically for extending XDP with
> multi-buffer support. One proposal is to use same layout as
> skb_shared_info, which is why this area is currently 320 bytes.
> 
> When converting xdp_frame to SKB (veth and cpumap), the full tailroom
> area can now be used and SKB truesize is now correct. For most
> drivers this result in a much larger tailroom in SKB "head" data
> area. The network stack can now take advantage of this when doing SKB
> coalescing. Thus, a good driver test is to use xdp_redirect_cpu from
> samples/bpf/ and do some TCP stream testing.

I did a quick look through the patches. Overall looks good to me.
Nice to see selftests as well.
If you can add an xdp selftest that uses generic xdp on lo or veth
that would be awesome.
I rarely run test_xdp*.sh tests, but run test_progs on every commit.
So having more comprehensive xdp test as part of test_progs will help us
catch breakage sooner.