netdev - Re: [PATCH net] hsr: check protocol version in hsr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 07 Apr 2020 18:35:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] hsr: check protocol version in hsr_newlink()

From: Taehee Yoo <ap420073@...il.com>
Date: Tue,  7 Apr 2020 13:23:21 +0000

> In the current hsr code, only 0 and 1 protocol versions are valid.
> But current hsr code doesn't check the version, which is received by
> userspace.
> 
> Test commands:
>     ip link add dummy0 type dummy
>     ip link add dummy1 type dummy
>     ip link add hsr0 type hsr slave1 dummy0 slave2 dummy1 version 4
> 
> In the test commands, version 4 is invalid.
> So, the command should be failed.
> 
> After this patch, following error will occur.
> "Error: hsr: Only versions 0..1 are supported."
> 
> Fixes: ee1c27977284 ("net/hsr: Added support for HSR v1")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied, thank you.