netdev - Re: [PATCH v2] net: qrtr: send msgs from local of same id as broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200408.125606.1078177957758077983.davem@davemloft.net>
Date:   Wed, 08 Apr 2020 12:56:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wenhu.wang@...o.com
Cc:     kuba@...nel.org, bjorn.andersson@...aro.org,
        cjhuang@...eaurora.org, tglx@...utronix.de, arnd@...db.de,
        hofrat@...dl.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...o.com
Subject: Re: [PATCH v2] net: qrtr: send msgs from local of same id as
 broadcast

From: WANG Wenhu <wenhu.wang@...o.com>
Date: Tue,  7 Apr 2020 20:32:47 -0700

> -		enqueue_fn = qrtr_bcast_enqueue;
> -		if (addr->sq_port != QRTR_PORT_CTRL) {
> +		if (addr->sq_port != QRTR_PORT_CTRL &&
> +			qrtr_local_nid != QRTR_NODE_BCAST) {

This is still not correct, it should be:

		if (addr->sq_port != QRTR_PORT_CTRL &&
		    qrtr_local_nid != QRTR_NODE_BCAST) {