lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed,  8 Apr 2020 22:27:06 +0200
From:   Arnd Bergmann <>
        Masahiro Yamada <>,
        Nicolas Pitre <>
Cc:     Arnd Bergmann <>, Andrzej Hajda <>,
        Neil Armstrong <>,
        Laurent Pinchart <>,
        Jonas Karlman <>,
        Jernej Skrabec <>,
        David Airlie <>,
        Daniel Vetter <>,
        Kieran Bingham <>,
        "David S. Miller" <>,
        Saeed Mahameed <>,
        Leon Romanovsky <>,,,,
Subject: [RFC 1/6] thunder: select PTP driver if possible

The 'imply' selection means the driver can still be a loadable
module even if the main driver is built-in, leading to a link

aarch64-linux-ld: drivers/net/ethernet/cavium/thunder/nicvf_main.o: in function `nicvf_remove':
nicvf_main.c:(.text+0x25c): undefined reference to `cavium_ptp_put'
aarch64-linux-ld: drivers/net/ethernet/cavium/thunder/nicvf_main.o: in function `nicvf_probe':
nicvf_main.c:(.text+0x3080): undefined reference to `cavium_ptp_get'

Use a 'select' statement instead.

Signed-off-by: Arnd Bergmann <>
 drivers/net/ethernet/cavium/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig
index 6a700d34019e..52806ef20d2d 100644
--- a/drivers/net/ethernet/cavium/Kconfig
+++ b/drivers/net/ethernet/cavium/Kconfig
@@ -27,7 +27,7 @@ config THUNDER_NIC_PF
 	tristate "Thunder Virtual function driver"
-	imply CAVIUM_PTP
 	depends on 64BIT && PCI
 	  This driver supports Thunder's NIC virtual function

Powered by blists - more mailing lists