netdev - Re: [PATCH] net/tls: fix const assignment warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200408.143439.2032281152789533700.davem@davemloft.net>
Date:   Wed, 08 Apr 2020 14:34:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     borisp@...lanox.com, aviadye@...lanox.com,
        john.fastabend@...il.com, daniel@...earbox.net, kuba@...nel.org,
        jakub@...udflare.com, dirk.vandermerwe@...ronome.com,
        simon.horman@...ronome.com, dcaratti@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/tls: fix const assignment warning

From: Arnd Bergmann <arnd@...db.de>
Date: Wed,  8 Apr 2020 20:54:43 +0200

> Building with some experimental patches, I came across a warning
> in the tls code:
> 
> include/linux/compiler.h:215:30: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   215 |  *(volatile typeof(x) *)&(x) = (val);  \
>       |                              ^
> net/tls/tls_main.c:650:4: note: in expansion of macro 'smp_store_release'
>   650 |    smp_store_release(&saved_tcpv4_prot, prot);
> 
> This appears to be a legitimate warning about assigning a const pointer
> into the non-const 'saved_tcpv4_prot' global. Annotate both the ipv4 and
> ipv6 pointers 'const' to make the code internally consistent.
> 
> Fixes: 5bb4c45d466c ("net/tls: Read sk_prot once when building tls proto ops")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.