netdev - [PATCH 1/4] net: mac80211: util.c: Fix RCU list usage warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200409082822.27314-1-madhuparnabhowmik10@gmail.com>
Date:   Thu,  9 Apr 2020 13:58:22 +0530
From:   madhuparnabhowmik10@...il.com
To:     johannes@...solutions.net, davem@...emloft.net, kuba@...nel.org
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, frextrite@...il.com,
        joel@...lfernandes.org, paulmck@...nel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
Subject: [PATCH 1/4] net: mac80211: util.c: Fix RCU list usage warnings

From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>

This patch fixes the following warning (CONIG_PROVE_RCU_LIST)
in ieee80211_check_combinations().

WARNING: suspicious RCU usage
[   80.933723] 5.6.0+ #4 Not tainted
[   80.933733] -----------------------------
[   80.933746] net/mac80211/util.c:3934 RCU-list traversed in non-reader section!!

Also, fix the other uses of list_for_each_entry_rcu() by either using
list_for_each_entry() instead (When mutex or spinlock is always held
in the function) or pass the necessary lockdep condition.

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
---
 net/mac80211/util.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index 20436c86b9bf..f4b0434024c0 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -254,7 +254,7 @@ static void __ieee80211_wake_txqs(struct ieee80211_sub_if_data *sdata, int ac)
 
 	sdata->vif.txqs_stopped[ac] = false;
 
-	list_for_each_entry_rcu(sta, &local->sta_list, list) {
+	list_for_each_entry(sta, &local->sta_list, list) {
 		if (sdata != sta->sdata)
 			continue;
 
@@ -719,7 +719,8 @@ static void __iterate_interfaces(struct ieee80211_local *local,
 	struct ieee80211_sub_if_data *sdata;
 	bool active_only = iter_flags & IEEE80211_IFACE_ITER_ACTIVE;
 
-	list_for_each_entry_rcu(sdata, &local->interfaces, list) {
+	list_for_each_entry_rcu(sdata, &local->interfaces, list,
+				(lockdep_is_held(&local->iflist_mtx)|| lockdep_rtnl_is_held())) {
 		switch (sdata->vif.type) {
 		case NL80211_IFTYPE_MONITOR:
 			if (!(sdata->u.mntr.flags & MONITOR_FLAG_ACTIVE))
@@ -3931,7 +3932,7 @@ int ieee80211_check_combinations(struct ieee80211_sub_if_data *sdata,
 		params.num_different_channels++;
 	}
 
-	list_for_each_entry_rcu(sdata_iter, &local->interfaces, list) {
+	list_for_each_entry(sdata_iter, &local->interfaces, list) {
 		struct wireless_dev *wdev_iter;
 
 		wdev_iter = &sdata_iter->wdev;
@@ -3982,7 +3983,7 @@ int ieee80211_max_num_channels(struct ieee80211_local *local)
 			ieee80211_chanctx_radar_detect(local, ctx);
 	}
 
-	list_for_each_entry_rcu(sdata, &local->interfaces, list)
+	list_for_each_entry(sdata, &local->interfaces, list)
 		params.iftype_num[sdata->wdev.iftype]++;
 
 	err = cfg80211_iter_combinations(local->hw.wiphy, &params,
-- 
2.17.1